Skip to content

Node.js 26.11.1 - #50

Merged
N6REJ merged 2 commits into
mainfrom
26.11.1
Oct 12, 2026
Merged

N6REJ merged 2 commits into
mainfrom
26.11.1

Conversation

@jwaisner

Copy link
Copy Markdown
Contributor

No description provided.

@jwaisner
jwaisner requested a review from N6REJ as a code owner October 12, 2026 04:03
@jwaisner jwaisner added the enhancement ✨ Improve program label Oct 12, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Add Bearsampp Node.js 26.11.1 bundle

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Add Node.js 26.11.1 bundle metadata and npm settings for Bearsampp integration.
• Add a launch script that sets the version-specific npm prefix and global configuration.
• Publish the new release URL and add npm prefixes for two existing versions.
Diagram

graph TD
  P["Build properties"] --> B["Gradle build"] --> V["Version bundle"] --> A["Release archive"] --> R["Release catalog"]
  V --> L["Launch script"] --> N["npm settings"]
Loading
High-Level Assessment

Follow the existing per-version bundle layout. Shared configuration generation could reduce duplication, but it would require a broader build change for a single-version addition.

Files changed (12) +36 / -1

Enhancement (1) +12 / -0
launch.batInitialize Node.js 26.11.1 and npm +12/-0

Initialize Node.js 26.11.1 and npm

• Derives the installed version path, writes npm's prefix, runs nodevars.bat, and sets npm's global configuration path.

bin/nodejs26.11.1/launch.bat

Other (11) +24 / -1
bearsampp.confRegister the Node.js 26.11.1 bundle +8/-0

Register the Node.js 26.11.1 bundle

• Declares the version, executable and launch paths, npm configuration path, and release placeholder used by Bearsampp.

bin/nodejs26.11.1/bearsampp.conf

npmrcConfigure npm paths for 26.11.1 +4/-0

Configure npm paths for 26.11.1

• Points npm's cache to Bearsampp's temporary directory and its configuration and init-module paths to the new version directory.

bin/nodejs26.11.1/etc/npmrc

npmrc.berAdd the 26.11.1 npm configuration template +4/-0

Add the 26.11.1 npm configuration template

• Mirrors the npm cache, configuration, and init-module settings in the companion .ber file.

bin/nodejs26.11.1/etc/npmrc.ber

npmrcSet the 24.21.0 npm prefix +1/-0

Set the 24.21.0 npm prefix

• Adds a Bearsampp-relative prefix pointing to the Node.js 24.21.0 directory.

bin/nodejs24.21.0/node_modules/npm/npmrc

npmrc.berMirror the 24.21.0 npm prefix +1/-0

Mirror the 24.21.0 npm prefix

• Adds the same version-specific prefix to the companion .ber file.

bin/nodejs24.21.0/node_modules/npm/npmrc.ber

npmrcSet the 26.11.1 npm prefix +1/-0

Set the 26.11.1 npm prefix

• Adds a Bearsampp-relative npm prefix pointing to the new version directory.

bin/nodejs26.11.1/node_modules/npm/npmrc

npmrc.berMirror the 26.11.1 npm prefix +1/-0

Mirror the 26.11.1 npm prefix

• Adds the new version's npm prefix to the companion .ber file.

bin/nodejs26.11.1/node_modules/npm/npmrc.ber

npmrcSet the 26.9.0 npm prefix +1/-0

Set the 26.9.0 npm prefix

• Adds a Bearsampp-relative prefix pointing to the Node.js 26.9.0 directory.

bin/nodejs26.9.0/node_modules/npm/npmrc

npmrc.berMirror the 26.9.0 npm prefix +1/-0

Mirror the 26.9.0 npm prefix

• Adds the same version-specific prefix to the companion .ber file.

bin/nodejs26.9.0/node_modules/npm/npmrc.ber

build.propertiesAdvance the bundle release identifier +1/-1

Advance the bundle release identifier

• Changes bundle.release from 2026.9.19 to 2026.10.11 for the new package.

build.properties

releases.propertiesList the Node.js 26.11.1 release archive +1/-0

List the Node.js 26.11.1 release archive

• Adds the download URL for the 26.11.1 archive under the 2026.10.11 release.

releases.properties

@qodo-code-review

qodo-code-review Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Node setup fails under paths with spaces ✓ Resolved
Description
launch.bat redirects its prefix output to %BEARSAMPP_NODEJS_CONFIG_PATH% without quoting the
expanded destination. When Bearsampp is installed under a path such as C:\Program Files\Bearsampp,
command parsing splits that filename, so the intended npm configuration is not written and the
launcher proceeds to configure npm.
Code

bin/nodejs26.11.1/launch.bat[8]

+ECHO prefix = %BEARSAMPP_NODEJS_PATH%>%BEARSAMPP_NODEJS_CONFIG_PATH%
Evidence
The launcher derives the npm configuration filename from its installation directory, uses it as an
unquoted redirection target, and then passes that filename to the npm configuration command.

bin/nodejs26.11.1/launch.bat[4-10]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new launcher uses an unquoted redirection target, so installation paths containing spaces prevent it from writing the intended npm configuration.
## Fix Focus Areas
- bin/nodejs26.11.1/launch.bat[4-10]
## Recommended Fix
Quote the expanded redirection destination on line 8. Use quoted `set "NAME=value"` assignments for paths so command metacharacters in the installation directory cannot break setup.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
Review mode: Auto: ⚖️ Balanced: Runtime packaging and launch configuration changes warrant careful review.

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread bin/nodejs26.11.1/launch.bat Resolved
Add proper quotes around environment variable assignments and file paths to handle spaces and special characters correctly in the launch.bat script.
@N6REJ
N6REJ merged commit dc5debd into main Oct 12, 2026
3 checks passed
@N6REJ
N6REJ deleted the 26.11.1 branch October 12, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants