Skip to content

Register default bff icons collection for core/icon block - #524

Merged
firestar300 merged 2 commits into
masterfrom
feature/register-icon-collections
Nov 3, 2026
Merged

firestar300 merged 2 commits into
masterfrom
feature/register-icon-collections

Conversation

@firestar300

@firestar300 firestar300 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
image

Note

Medium Risk
Changes editor block availability and replaces the default core icon library with theme SVGs, so missing builds or WP versions without the new APIs would yield an empty or unexpected icon picker.

Overview
Adds an Icon framework service that registers General (beapi-sprite) and Social (beapi-social) icon collections for WordPress’s core/icon block (7.1+), scanning built SVGs under dist/images/{sprite,social} and exposing bff_icon_collections, bff_icon_label, and bff_icon_properties filters for customization.

By default it removes the core WordPress icon collection from the picker (bff_unregister_core_icon_collection), and the block editor allowlist stops blacklisting core/icon so editors can use the block with theme icons. SVGO config gets a small comment only; no behavior change there.

Reviewed by Cursor Bugbot for commit c978678. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread inc/Services/Icon.php Resolved
Comment thread inc/Services/Icon.php Resolved
francoistibo
francoistibo previously approved these changes Nov 2, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c978678. Configure here.

Comment thread inc/Services/Icon.php Resolved
@firestar300
firestar300 merged commit 6004d8e into master Nov 3, 2026
6 checks passed
@firestar300
firestar300 deleted the feature/register-icon-collections branch November 3, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants