Repository navigation
fix: keep EmailNotVerified/NoPaymentHistory type in B2Session - #669
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
The session rebuilt every Unauthorized as the base class, so EmailNotVerified and NoPaymentHistory could not be caught and their should_retry_upload() = False was lost.
patrick-immometrica
marked this pull request as ready for review
November 15, 2026 14:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_add_app_key_info_to_unauthorizedalways returns a plainUnauthorized, soEmailNotVerifiedandNoPaymentHistoryraised by the server lose their type on the way out ofB2Session.Two effects: callers can't catch them, and
should_retry_upload()goes back toTrue. An upload on an account without a verified email or payment history is then retriedMAX_UPLOAD_ATTEMPTStimes and ends inMaxRetriesExceededinstead of failing with the real error.The fix keeps the original class. All
Unauthorizedsubclasses that can reach this helper share its(message, code)constructor.