Repository navigation
fix: hidden source file is not deleted in b2-to-b2 sync - #668
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
Copy policies passed a hidden source path straight to the delete and keep-days helpers, which only check for None. The destination file was kept even with --delete.
patrick-immometrica
marked this pull request as ready for review
November 15, 2026 14:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When syncing bucket to bucket with
--delete(or--keep-days), a file that is hidden in the source stays visible in the destination forever.CopyAndDeletePolicyandCopyAndKeepDaysPolicypass the hidden source path tomake_b2_delete_actions/make_b2_keep_days_actions, and those only treatNoneas "no source". The down-sync path already checksis_visible()(#96), so I did the same in the two helpers.Covers the b2 destination part of #167. Both new tests fail on master.