Skip to content

fix: hidden source file is not deleted in b2-to-b2 sync - #668

Open
patrick-immometrica wants to merge 1 commit into
Backblaze:masterfrom
patrick-immometrica:fix-copy-sync-hidden-source
Open

patrick-immometrica wants to merge 1 commit into
Backblaze:masterfrom
patrick-immometrica:fix-copy-sync-hidden-source

Conversation

@patrick-immometrica

Copy link
Copy Markdown

When syncing bucket to bucket with --delete (or --keep-days), a file that is hidden in the source stays visible in the destination forever.

CopyAndDeletePolicy and CopyAndKeepDaysPolicy pass the hidden source path to make_b2_delete_actions / make_b2_keep_days_actions, and those only treat None as "no source". The down-sync path already checks is_visible() (#96), so I did the same in the two helpers.

Covers the b2 destination part of #167. Both new tests fail on master.

Copy policies passed a hidden source path straight to the delete and
keep-days helpers, which only check for None. The destination file was
kept even with --delete.
@patrick-immometrica
patrick-immometrica marked this pull request as ready for review November 15, 2026 14:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant