Repository navigation
fix: recognize completed large files after finish errors - #264
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
A lost response from
b2_finish_large_filecan cause a retry to return HTTP 400 even though the file was completed. Checkb2_get_file_infoafter a bad request and return the file version when its action isupload. If the file is unfinished or its info cannot be retrieved, preserve the original finish error.The service now waits for an in-progress finish before returning 400, so this check can reliably confirm completion. The change applies to all existing finish callers without changing retry policy or public APIs.
Testing and validation
Result: main with regression tests has 1 failure out of 61; the fix passes all 61.
check_codepasses for production sources and both changed files when run with host Python. Running it over the entire test tree reports 30 pre-existing license/layering errors outside the changed files.Regression tests cover a completed upload, an unfinished file, and a failed file-info request. The existing finish request test remains unchanged.
This change and its regression tests were prepared with AI assistance (Codex).