Repository navigation
fix: resume large file uploads with the stored large-file SHA1 - #262
Open
MatheoPaiva wants to merge 1 commit into
Open
MatheoPaiva wants to merge 1 commit into
MatheoPaiva wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249
Use the unfinished large file's
large_file_sha1value when building the sample upload request.content_sha1isnonefor unfinished large files, while the resume validation compares againstlarge_file_sha1, so the sample rejected its own resume operation.Validation: cross-checked the sample against
B2LargeFileUploader.throwIfLargeFileVersionDoesntSeemToMatchRequestand theB2ContentWriterSHA1 handling. Java compilation and tests were not run because a Java compiler is unavailable in this environment.AI assistance: prepared with OpenAI Codex.