Skip to content

build: harden release publication and checks - #1223

Open
ffumero2003 wants to merge 2 commits into
release-standard-changie-oidcfrom
release-standard-oidc-signing
Open

ffumero2003 wants to merge 2 commits into
release-standard-changie-oidcfrom
release-standard-oidc-signing

Conversation

@ffumero2003

Copy link
Copy Markdown
Contributor

Context

This stacks on the Changie migration in #1221 and completes the release workflow update tracked in #1222.

Changes

  • Verify SSH-signed release tags against an in-repo maintainer key before publishing.
  • Gate readable open medium, high, and critical security findings. Report unreadable sources as UNVERIFIED; SECURITY_GATE_STRICT can hold on them after code and secret scanning are enabled.
  • Publish Python distributions through PyPI Trusted Publishing with attestations and a SHA-pinned PyPA action. Keep DigiCert bundle signing and Docker Hub image publishing.
  • SHA-pin actions, align Docker build/push at v5, replace the selected community actions with direct tooling, and document the full release process in RELEASE.md.

Verification

  • nox -vs lint changie_check build: passed.
  • nox -vs unit: passed on PyPy 3.10 and CPython 3.10–3.14; each of three CLI variants passed in every interpreter session.
  • Release workflow tests: 8 passed.
  • actionlint and shellcheck: passed. The local actionlint build predates GitHub's vulnerability-alerts permission, so only that known parser diagnostic was excluded.
  • Local security gate: Dependabot clear, code and secret scanning loudly UNVERIFIED (their alert APIs currently return 404), no blocking readable-source findings.
  • Throwaway-worktree make_release_commit -- 5.0.4: passed and generated Changie notes without publishing or tagging.

PyPI Trusted Publisher and the protected pypi environment require one-time maintainer configuration before the first tag. Strict mode requires code and secret scanning to be enabled and readable. The release workflow itself has not been published in a dry run.

Closes #1222

Verify signed release tags and security findings before publication. Use trusted publishing, pinned actions, and direct release tooling while preserving bundle signing and Docker output.
@ffumero2003 ffumero2003 self-assigned this Nov 17, 2026
@ffumero2003
ffumero2003 requested a review from goanpeca November 17, 2026 21:37
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1

  • release-2025-v*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 42f619b2-dcf7-45c9-b341-3b924684fa90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant