Annual Position Review Button

[johnlolonga19]

Fixes issue #618

• The Labor Office should be able to initiate the annual position review process for every department from the Manage Departments page.

• This workflow requests departments to review their position descriptions and submit any necessary updates before the next academic year.

Additions

• A working "Annual Position Review" button on the Manage Departments page. Clicking it opens a confirmation window explaining what's about to happen.

• An "Edit Email Template" option in that confirmation window, so an admin can review or change the wording of the email before sending it.

• A "Submit Request" button that actually sends the request. Once sent, every active department's supervisors and Labor Coordinators receive an email asking them to review their positions for the current academic year.

• A confirmation message on screen after sending, showing how many departments the request went out to.
  The system now keeps a record of when a review was requested for each department and academic year, and who requested it, so re-sending a request updates that record instead of creating duplicates.

Changes

• annualPositionReview.html — the previously-stubbed confirmation modal (empty onclick="" on every button) is now fully wired: Submit Request calls the new JS, Edit Email Template links to emailTemplates linked to this template

• manageDepartments.html loads annualPositionReview.js; the trigger button now carries data-academic-year so the JS knows which academic year is selected.

• manageDepartments() view now also passes the chosenAY Term object into the template context (previously only chosenAY.termName was passed), needed for the data-academic-year attribute above.

• emailTemplates.js added prefillFromQueryParams() so the Email Templates editor can be linked with Recipient/Form Type/Action pre-selected (used by the Edit Email Template link above)

• The confirmation page and its buttons (Cancel, Edit Email Template, Submit Request) previously did nothing when clicked they're now fully functional.

• The email template editor page can now be opened directly from the confirmation window with the right template already selected, instead of requiring the admin to fill it manually.

• Added the test suite for annualPositionReview.py

• Moved the logic from annualPositionReview.py to emailHandler.py to avoid duplicating the function

Testing

• ALWAYS_SEND_MAIL was set to False in local secret_config.yaml (untracked, not part of this PR) so local testing doesn't attempt a real SMTP send.

• To submit an annual position review, on the sidebar menu, click Admin

• Then click the " Manage Department " that will take you to the page

• On the page click "Annual Position Review" and then " Submit Request"

• A message will show that the request has been sent to x departments out of y.

• Two ways to edit email template through Manage Department and Manage Email Template:

  • To edit the email template inside the, click on "Edit Email Template" that will prefill the Position Review components
  • Or inside Manage Email Template, fill the fields for the Position Review Email and will allow you to edit
  • And you can save the changes or discard

[ArtemKurasov]

The code is good overall, but I saw several print statements in the code. You should consider deleting them if they serve no purpose other than debugging

[MImran2002]

we should try to work off from positionhistory model

[MImran2002]

we don't need a positionreview table. we can base off the logic and insert data with positionhistory

[MImran2002]

There is a merge conflict happening

[MImran2002]

I don't think reviewing means creating a positionhistory

[MImran2002]

we don't need a positionreview table. we can base off the logic and insert data with positionhistory

[MImran2002]

run prefill function should be outside of this function because it restricts the scope of how the function can be used.