Skip to content

All Celts Training now appears in participation history - #1811

Open
MImran2002 wants to merge 2 commits into
developmentfrom
actPastEventHF
Open

MImran2002 wants to merge 2 commits into
developmentfrom
actPastEventHF

Conversation

@MImran2002

@MImran2002 MImran2002 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Issue Description

Fixes issue #1810

  • For All Celts Training (Labor), the student who was manually added after event has finished does not have the event shown up in their participation history. This prevents the student from signing the handbook.

Changes

  • Removes isCeltsTraining filter from the query in getparticipatedEventsForUser function so that it also includes All CELTS Training (Labor) in the return value.
  • Added test case for the All CELTS Training (Labor) being returned from the function.

Testing

  • Checkout the branch git checkout actPastEventHF
  • Pull the code when you are in the branch git pull
  • Run the test by resetting the database ./database/reset_database.sh test and run the test ./tests/run_tests.sh
  • Create a All Celts Training (Labor) in create event and set the date to past.
  • After the event is created, go to manage volunteers and add Zach Neill as a volunteer.
  • Go to his profile to see that he has participated the event underneath Participation History accordion
  • He will also be able to sign the handbook as long as he didn't sign a different handbook prior.

@bakobagassas
bakobagassas self-requested a review September 15, 2026 15:21
Comment thread app/logic/events.py
.join(EventParticipant)
.where(EventParticipant.user == user,
Event.isAllVolunteerTraining == False, Event.deletionDate == None, Event.isCeltsTraining == False)
Event.isAllVolunteerTraining == False, Event.deletionDate == None)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple of questions about this fix. Will ask in person.

@bakobagassas bakobagassas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know when it is ready for another review

@github-actions

Copy link
Copy Markdown

View Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants