Fixing the List of Summer Terms on the Request Summer Proposal page by ArtemKurasov · Pull Request #1767 · BCStudentSoftwareDevTeam/celts

ArtemKurasov · 2026-07-17T14:49:58Z

Issue Description

Fixes issue #1747

If you request a summer proposal on a CCE Minor Profile page, you don't have enough Summer terms to choose from

Changes

There are now more Summer Terms options for the CCE Minor Proposal Form
The options reflect the academic year of a student (for example, if they are a freshman, they will 4 options, but if they are not, they will have less).

Testing

Go to Admin > Minor Management
Choose different students on the CCE Minor Progress list/table
Click on the Request Summer Proposal button
Click on the Summer Year dropdown
Make sure that the displayed years match the Student's academic year

… student

brightfietsop-ux · 2026-08-07T18:41:07Z

Fixes issue ##1747

Summary

Updated the CCE Minor Summer Experience form so students see summer years based on their estimated enrollment period.

What Changed

Added selectAllSummerTerms() to estimate a student’s admission year using:
- Current class level
- Current academic term
- Graduation status
Limited the dropdown to summers within the student’s estimated enrollment window.
Included the current summer when the student is still enrolled.
Prevented graduated students from receiving summer options.
Updated dropdown options to use explicit Term IDs.
Removed unused or broken JavaScript references from the form.
Added Summer 2018–2020 to the demo/test data using non-conflicting IDs.

For example, a Senior in Summer 2021 sees Summer 2018–2021, while a Sophomore sees Summer 2020–2022.

Testing

Added tests covering:

Freshman, Sophomore, and Senior enrollment windows
Current-summer behavior
Graduated students
Missing or unrecognized class levels
Exclusion of summers beyond the estimated graduation window

… student

…ght_Artem

MImran2002 · 2026-09-08T13:55:20Z

+    """
+    Select the summer terms during which a CCE Minor student could be enrolled.
+
+    The user record does not store an admission date, so the admission academic


docstrings should give a reason for input and what returns and a single sentence of what it should do.

MImran2002 · 2026-09-08T14:38:40Z

  {{ super() }}
  <script type="module" src="/static/js/minorProfilePage.js"></script>
  <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery.inputmask/3.3.4/jquery.inputmask.bundle.min.js"></script>
-  <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.5.4/bootstrap-select.js"></script>


why are these remove?

MImran2002 · 2026-09-08T14:40:35Z

+    ],
+)
+def test_selectAllSummerTerms_uses_estimated_enrollment_window(
+        class_level, current_description, current_year, expected_years):


make sure to test graduating too as you have special logic for graduating when populating for the student.

MImran2002 · 2026-09-11T13:21:51Z

+
+    firstSummer = inferredAdmissionYear + 1
+    lastSummer = inferredAdmissionYear + max(4, classYear) - 1
+    if currentTerm.description.startswith("Summer"):


currentTerm.isSummer should and can be use here as we have a field for this.

MImran2002 · 2026-09-11T13:28:46Z

+    # A Spring/Summer term belongs to the academic year that began the prior fall.
+    academicYearStart = (currentTerm.year if currentTerm.description.startswith("Fall")
+                         else currentTerm.year - 1)
+    inferredAdmissionYear = academicYearStart - (classYear - 1)


what we can do here is a way to shrink these lines 63,65,66 to two lines in two of these forms:

eg 1:
firstSummer = (academicYearStart - (classYear - 1)) + 1
lastSummer = (firstSummer - 1) + max(4, classYear) - 1

eg2:

firstSummer, lastSummer = inferredAdmissionYear + 1, inferredAdmissionYear + max(4, classYear) - 1```

Can we simplify it even further?

firstSummer = academicYearStart - classYear + 2 lastSummer = firstSummer + max(4, classYear) - 2

MImran2002 · 2026-09-11T13:40:53Z

                        {% endif %}
                        {% for term in selectableTerms %}
-                            <option value="{{ term }}" 
+                            <option value="{{ term.id }}"


changing it from term to term.id doesn't really matter as i tried doing {{ term.description }}, {{term}}, {{term.id}} and term and term.id are the same.

MImran2002 · 2026-09-11T13:53:50Z

@@ -1,6 +1,9 @@
 import pytest
+from types import SimpleNamespace


we do not use SimpleNamespace unless we are trying to let's say fake a request in the test so that we can avoid create a whole class for it. For instance: mockRequestProposalObject = SimpleNamespace(
form=defaultProposal,
files=SimpleNamespace(
getlist=lambda key: [],
get=lambda key: None
), in test_nimor.py file. Here your simplenamespace is just use to convert traditional dictionary access into attribute access. but, if my understanding is wrong and there is a rationale do tell me that can change my comment.

MImran2002 · 2026-09-11T13:54:32Z

+                        isCurrentTerm=False,
+                        termOrder=f"{year}-2")
+
+        student = SimpleNamespace(rawClassLevel=class_level,


From the above comment regarding simplenamespace convert those so that it reflects the dictionary usage.

…areDevTeam/celts into 1747_Bright_Artem

github-actions · 2026-09-17T22:02:24Z

View Code Coverage

ArtemKurasov added 2 commits July 16, 2026 16:46

Seemingly fixed issue 1747

f341849

Adding an edge case scenario for graduating students and superseniors

0615297

ArtemKurasov requested a review from BrianRamsay July 17, 2026 14:49

ArtemKurasov assigned brightfietsop-ux and ArtemKurasov Jul 17, 2026

Correctly displaying previous years reflecting the academic year of a…

36ef8eb

… student

ArtemKurasov marked this pull request as ready for review July 17, 2026 15:53

fixed the dropdown issue on manage proposal for summer years and year

48477ca

brightfietsop-ux requested a review from MImran2002 August 6, 2026 21:42

brightfietsop-ux and others added 3 commits August 7, 2026 14:04

Merge branch 'development' into 1747_Bright_Artem

bd79a13

New production backup

4114367

added a test suit for my function

c8274a2

ArtemKurasov and others added 8 commits August 7, 2026 14:59

Seemingly fixed issue 1747

f00a23f

Adding an edge case scenario for graduating students and superseniors

005c3d1

Correctly displaying previous years reflecting the academic year of a…

fd09690

… student

fixed the dropdown issue on manage proposal for summer years and year

928f1e3

added a test suit for my function

818663c

Merge remote-tracking branch 'origin/1747_Bright_Artem' into 1747_Bri…

ebb2bad

…ght_Artem

Merge branch 'development' into 1747_Bright_Artem

707b93a

Merge branch 'development' into 1747_Bright_Artem

810640c

MImran2002 requested changes Sep 8, 2026

View reviewed changes

ArtemKurasov removed their assignment Sep 8, 2026

MImran2002 added 2 commits September 10, 2026 08:48

Merge branch 'development' into 1747_Bright_Artem

9bd0254

Merge branch 'development' into 1747_Bright_Artem

dbabdb7

MImran2002 requested changes Sep 11, 2026

View reviewed changes

ArtemKurasov assigned ArtemKurasov and brightfietsop-ux and unassigned brightfietsop-ux Sep 17, 2026

Merge branch 'development' into 1747_Bright_Artem

9b37659

ArtemKurasov added 2 commits September 17, 2026 17:41

Merge branch '1747_Bright_Artem' of https://github.com/BCStudentSoftw…

6ddbc23

…areDevTeam/celts into 1747_Bright_Artem

Updated the CCE Summer Proposal page so it can only be for students

6c73a5e

Navigation Menu

Fixing the List of Summer Terms on the Request Summer Proposal page - #1767

Fixing the List of Summer Terms on the Request Summer Proposal page#1767
ArtemKurasov wants to merge 20 commits into
developmentfrom
1747_Bright_Artem

ArtemKurasov commented Jul 17, 2026 •

edited

Loading

Uh oh!

brightfietsop-ux commented Aug 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

MImran2002 Sep 8, 2026

Uh oh!

Uh oh!

MImran2002 Sep 8, 2026

Uh oh!

MImran2002 Sep 8, 2026

Uh oh!

MImran2002 Sep 11, 2026

Uh oh!

MImran2002 Sep 11, 2026

Uh oh!

ArtemKurasov Sep 17, 2026

Uh oh!

MImran2002 Sep 11, 2026

Uh oh!

MImran2002 Sep 11, 2026

Uh oh!

MImran2002 Sep 11, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -1,6 +1,9 @@
		import pytest
		from types import SimpleNamespace

Conversation

ArtemKurasov commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Description

Changes

Testing

Uh oh!

brightfietsop-ux commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Testing

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ArtemKurasov commented Jul 17, 2026 •

edited

Loading

brightfietsop-ux commented Aug 7, 2026 •

edited

Loading