Fix NameError: import Deadline model in deadlineManagement.py - #112
Open
baobao1355 wants to merge 1 commit into
Open
baobao1355 wants to merge 1 commit into
baobao1355 wants to merge 1 commit into
Conversation
MImran2002
approved these changes
Sep 15, 2026
MImran2002
left a comment
There was a problem hiding this comment.
I will approve this PR but the next PR I would require the contributor to create a proper PR description in the format like this:
Issue Description
Fixes issue #<issue_number>
- Add issue description
Changes
- Use bullet points to provide a description of added changes.
- Add images, where possible, to provide more context to your changes.
Testing
- Use backticks to highlight shell commands or file directories in your test descriptions.
- Use bullet points to provide a concise description of testing procedure.
Moreover, you did well with structuring the imports according to this repo the standard is to import in this order general/system import > logic > model
Author
|
Thank you! I will do that in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NameError was because the Deadline model was not imported. I fixed by adding from app.models import Deadline to the top of deadlineManagement.py