Skip to content

Fix NameError: import Deadline model in deadlineManagement.py - #112

Open
baobao1355 wants to merge 1 commit into
developmentfrom
deadline-nameerror
Open

baobao1355 wants to merge 1 commit into
developmentfrom
deadline-nameerror

Conversation

@baobao1355

Copy link
Copy Markdown

The NameError was because the Deadline model was not imported. I fixed by adding from app.models import Deadline to the top of deadlineManagement.py

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this PR but the next PR I would require the contributor to create a proper PR description in the format like this:

Issue Description
Fixes issue #<issue_number>

  • Add issue description

Changes

  • Use bullet points to provide a description of added changes.
  • Add images, where possible, to provide more context to your changes.

Testing

  • Use backticks to highlight shell commands or file directories in your test descriptions.
  • Use bullet points to provide a concise description of testing procedure.

Moreover, you did well with structuring the imports according to this repo the standard is to import in this order general/system import > logic > model

@baobao1355

Copy link
Copy Markdown
Author

Thank you! I will do that in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants