Repository navigation
fix: escape password slashes in connection URIs - #980
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your submission, we really appreciate it. We ask that you sign our Contributor License Agreement before we can accept your contribution. If you are contributing on behalf of your employer you must fill out our Corporate Contributor License Agreement which can be found here. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passwords containing
/break the generated PostgreSQL URI becauseurllib.parse.quoteleaves slashes unescaped by default. For example,one/twois parsed as part of the URI path rather than remaining within the password.Use
safe=""when encoding passwords in all three connection URI properties: root, owner, and pglogical. Other connection configuration is unchanged.Validation:
python -m pytest tests/pgbelt -q -p no:cacheprovider --basetemp .pytest-tmp-uri.git diff --checkpass.