Skip to content

fix: escape password slashes in connection URIs - #980

Open
Shubham-Padkonde wants to merge 1 commit into
Autodesk:mainfrom
Shubham-Padkonde:fix/escape-password-uri-slashes
Open

Shubham-Padkonde wants to merge 1 commit into
Autodesk:mainfrom
Shubham-Padkonde:fix/escape-password-uri-slashes

Conversation

@Shubham-Padkonde

Copy link
Copy Markdown

Passwords containing / break the generated PostgreSQL URI because urllib.parse.quote leaves slashes unescaped by default. For example, one/two is parsed as part of the URI path rather than remaining within the password.

Use safe="" when encoding passwords in all three connection URI properties: root, owner, and pglogical. Other connection configuration is unchanged.

Validation:

  • All 113 unit tests pass: python -m pytest tests/pgbelt -q -p no:cacheprovider --basetemp .pytest-tmp-uri.
  • Twelve cases verify decoded passwords and the unchanged host, port, username, and database path across the three roles. Nine cases fail before the fix.
  • Black formatting and git diff --check pass.
  • Docker/PostgreSQL integration tests were not run because the Docker daemon is unavailable in this environment. Existing dependency deprecation warnings remain.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your submission, we really appreciate it. We ask that you sign our Contributor License Agreement before we can accept your contribution.

If you are contributing on behalf of your employer you must fill out our Corporate Contributor License Agreement which can be found here.
If you are contributing on behalf of yourself you must agree to our Individual Contributor License Agreement by reviewing this document and signing it or by replying below a with a comment containing the following text:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant