Repository navigation
chore: restore and modernize Core PDF packages - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core shipped PDF artifacts contain functionality missing from this fork's accessible Phase 22 source. Restore the five consumed packages from Core's committed source maps and declarations, then modernize them as a coordinated, versioned 0.1.0 cohort. Preserve existing exports, supported document versions, variables/repeaters/calculations, migration reports and server-only DocRaptor boundaries. Native-builder activation stays disabled.
The maintained source uses pnpm 12.14.0, Node 24.22.1, React 19.3.1, the public React Email editor 1.7.14, Tiptap 3.32.0 and Zod 4.6.7. Product compilation uses TypeScript 7.0.2; the declaration builder retains the current supported 6.0.3 compiler API with physical-identity tests. Current Rolldown 1.2.15 and PostCSS 8.5.31 resolve through supported parent ranges. Formatting-only documentation changes are separately committed and structurally verified.
Real Chromium tests caught and fixed page-break HTML parsing as an ordinary horizontal rule. A supported whole-project declaration build fixes nondeterministic schema declarations without changing runtime schemas. CI now checks three byte-identical build/pack rounds and detects source mutations, including already-dirty files and symlinks.
Validation: frozen installation; all five packages' lint/typecheck/build and 224 unit cases; upstream editor 447 passing cases and one existing skip; three real browser cases; eight retained document categories; three identical artifact rounds; independent source/lock/security review. Full and production audits contain zero advisory paths for the five consumed importers, including build tools. The separate legacy workspace graph still has findings and is not qualified by this change. Rendering is local Chromium with bounded synthetic assets; live DocRaptor and final provider fidelity remain separate.
Two independent clean checkouts of committed source cc171a1 pass frozen installation and all package gates, with three identical artifact rounds in each. The published artifact-release.json records exact tarball and packaged-file hashes; the final documentation commit changes no package or build inputs. All seven source-head CI checks passed. Final-head owner CI/review/merge, Core artifact ingestion and downstream deployed qualification remain required. See docs/maintenance/core-pdf-modernization/ for provenance, exact versions, preserved contracts and evidence limits.