Repository navigation
fix(streaming): add non-negative validation constraints to RealTimeTr… - #255
Merged
ccampbell-aai merged 3 commits intoSep 29, 2026
Conversation
…anscriberOptions Enforce ge=0 boundary validation via Field constraints on: - connect_timeout (timeout waiting for WebSocket handshake) - max_connection_retries (retry attempts after handshake failure) - connection_retry_delay (delay in seconds between retry attempts) - terminate_timeout (timeout waiting for server TerminationEvent) Previously, negative values were accepted without error, leading to empty retry loops or unexpected immediate socket disconnections. Added unit tests covering negative rejections and zero boundary acceptance.
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
ccampbell-aai
requested changes
Sep 20, 2026
ccampbell-aai
left a comment
ccampbell-aai
left a comment
Contributor
There was a problem hiding this comment.
Hey @shobhitagnihotri69 thanks for flagging this! One minor change requested in-line, and please include a patch version bump as well.
….5.6 Per maintainer review by @ccampbell-aai: - Update connect_timeout Field constraint to gt=0 as zero is an invalid timeout - Update test cases to reject zero connect_timeout - Bump version to 1.5.6
Contributor
Author
|
Thanks @ccampbell-aai! I have updated the |
# Conflicts: # assemblyai/__version__.py
ccampbell-aai
approved these changes
Sep 29, 2026
Contributor
|
Hey @shobhitagnihotri69 , thanks for fixing those changes and apologies this got lost on my end for a bit. I went ahead and fixed the version conflict that came up and merged your changes in. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…anscriberOptions
Enforce ge=0 boundary validation via Field constraints on:
Previously, negative values were accepted without error, leading to empty retry loops or unexpected immediate socket disconnections. Added unit tests covering negative rejections and zero boundary acceptance.