Repository navigation
feat(ui-egui): drag notebooks, sections and pages in the navigation pane - #395
Open
leifrossau wants to merge 6 commits into
Open
leifrossau wants to merge 6 commits into
leifrossau wants to merge 6 commits into
Conversation
node.place puts a page, section, section group or notebook just before one of its new neighbours, or last: where a drag in the navigation pane drops it. It takes an order between its neighbours, so only the node placed is written; the others are renumbered only when no number is left between. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As in OneNote: a row taken hold of is carried, and the row under the pointer shows where it would go - a line above or below it, or an outline when it would go into it. A page goes among pages, into a section, or onto another page as its subpage; a section among sections or into a notebook or section group; a notebook among notebooks, wherever each is kept. Escape puts it back, and a press that hardly moves is still a click. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The navigation pane can now be arranged by dragging, as in OneNote. Before, the only ways were the context menu's Move Up and Move Down (one place at a time, pages only) and the Move or Copy dialog.
notebook_order), so nothing in the notebooks is written.A new command,
node.place(path, to, before), puts a node just before one of its new neighbours, or last. It takes an order number between its neighbours', so only the node placed is written. The others are renumbered only when no number is left between them. Move Up and Move Down renumber the whole section, which on a synced folder (OneDrive through onedriver) waits on the mount once per page.Quality level L3 (see SKILLS/nc-devx/SKILL.md)
cargo xtask pre-pushpasses on the current branch before pushingorigin/maincoveragejob's warnings are read;cargo xtask coverage --updateis inthis pull request if coverage rose
docs/commands.mdregenerated fornode.placeCommandSpecwith a test (node.place)assets/ordocs/images/have a row inATTRIBUTION.md(none added)How it was checked
cargo xtask pre-pushon this branch.notebooks_sections_and_pages_are_dragged_where_they_go(UI) drags in the window and checks each result:navdragunit tests for where a drop goes.a_node_is_placed_where_it_was_dropped_writing_only_itself(store): checks that only the moved page's file changes, and that the section is renumbered when no gap is left.a_page_is_placed_before_another_or_lastandnotebooks_keep_the_order_they_were_dragged_into(engine): the notebooks come from two folders, and the order is still there after reopening.🤖 Generated with Claude Code