Skip to content

fix(ui-egui): move a printout as one, and undo a drag in one step - #392

Open
leifrossau wants to merge 4 commits into
AlienTechSoftware:mainfrom
leifrossau:fix/printout-moves-whole
Open

leifrossau wants to merge 4 commits into
AlienTechSoftware:mainfrom
leifrossau:fix/printout-moves-whole

Conversation

@leifrossau

Copy link
Copy Markdown
Collaborator

What and why

  • Taking hold of a page of a printout lifted just that page out of its box ([BUG] Cannot freely move an existing image around the page #344's lift), splitting the printout. Any page now brings its card and the other pages of the same file along (printout_blocks): a box holding only the printout moves, and a printout in a box shared with words is lifted out whole.
  • A box drag recorded an undo step every frame, so Ctrl+Z went back one frame at a time and a long drag could push older steps out of the 200-step history. The frames of one press now fold into one step (history::Kind::Moving), taken after the page's text is rebuilt so the step holds the boxes where they are.

Quality level L3 (see SKILLS/nc-devx/SKILL.md)

  • cargo xtask pre-push passes on the current branch before pushing
  • The pre-push hook confirms the validation still matches origin/main
  • CI checks pass for this pull request
  • Coverage: the coverage job's warnings are read; cargo xtask coverage --update is in
    this pull request if coverage rose
  • Docs match the change: no command, control-protocol or gap changes
  • A new user action is a CommandSpec with a test (no new user action)
  • Page or demo changes: none
  • UI changes: no visual change
  • New files under assets/ or docs/images/ have a row in ATTRIBUTION.md (none added)

How it was checked

  • cargo xtask pre-push on this branch.
  • Tests a_printout_moves_as_one_and_undo_puts_it_back (fails without the change), a_printout_is_its_card_and_every_page, one_drag_is_one_step; a_picture_in_a_shared_box_is_moved_by_dragging_it still passes.

🤖 Generated with Claude Code

leifrossau and others added 4 commits November 18, 2026 20:03
Taking hold of any page of a printout brings its card and its other pages
along: a box holding just the printout moves, and a printout in a box shared
with words is lifted out whole rather than page by page.

A box drag recorded an undo step every frame, so Ctrl+Z went back one frame
at a time and a long drag could push older steps out of the history. The
frames of one press now fold into one step, taken after the page's text is
rebuilt so the step holds the boxes where they are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants