Repository navigation
fix(ui-egui): move a printout as one, and undo a drag in one step - #392
Open
leifrossau wants to merge 4 commits into
Open
leifrossau wants to merge 4 commits into
leifrossau wants to merge 4 commits into
Conversation
Taking hold of any page of a printout brings its card and its other pages along: a box holding just the printout moves, and a printout in a box shared with words is lifted out whole rather than page by page. A box drag recorded an undo step every frame, so Ctrl+Z went back one frame at a time and a long drag could push older steps out of the history. The frames of one press now fold into one step, taken after the page's text is rebuilt so the step holds the boxes where they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
printout_blocks): a box holding only the printout moves, and a printout in a box shared with words is lifted out whole.history::Kind::Moving), taken after the page's text is rebuilt so the step holds the boxes where they are.Quality level L3 (see SKILLS/nc-devx/SKILL.md)
cargo xtask pre-pushpasses on the current branch before pushingorigin/maincoveragejob's warnings are read;cargo xtask coverage --updateis inthis pull request if coverage rose
CommandSpecwith a test (no new user action)assets/ordocs/images/have a row inATTRIBUTION.md(none added)How it was checked
cargo xtask pre-pushon this branch.a_printout_moves_as_one_and_undo_puts_it_back(fails without the change),a_printout_is_its_card_and_every_page,one_drag_is_one_step;a_picture_in_a_shared_box_is_moved_by_dragging_itstill passes.🤖 Generated with Claude Code