Repository navigation
feat(ui-egui): open where the window was left - #391
Open
leifrossau wants to merge 5 commits into
Open
leifrossau wants to merge 5 commits into
leifrossau wants to merge 5 commits into
Conversation
The window came back to the page it last remembered, but a page in a notebook kept outside the notebooks folder (one in a synced folder, say) was never remembered: its path was only ever stored relative to the notebooks folder, so the window kept opening an old page instead. It is now remembered by its whole path, and the tree opens down to it. It also comes back at the zoom it was left at and scrolled to the same place on the page, both kept when the window closes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scroll was set before the page was tall enough, past its end. egui sprang it back with a great speed; the page coasted far from the place, and the scroll area kept asking for frames, so the window redrew sixty times a second with nothing happening. The place is now set once the page reaches it, tried for a few seconds while pictures arrive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t-off # Conflicts: # crates/ui-egui/src/app.rs
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The window opens on the page it closed on, at the same zoom and scroll. A notebook kept outside the notebooks folder (a synced folder) is remembered by the page's whole path; before,
last_pagewas not remembered for it at all. A note window of its own does not change what the main window remembers.The scroll is set only once the page is tall enough to reach it, tried for a few seconds while pictures arrive. Set earlier, past the page's end, egui sprang it back with a great speed: the page coasted far from the place and the scroll area went on asking for frames, so the window redrew sixty times a second with nothing happening.
Quality level L3 (see SKILLS/nc-devx/SKILL.md)
cargo xtask pre-pushpasses on the current branch before pushingorigin/maincoveragejob's warnings are read;cargo xtask coverage --updateis inthis pull request if coverage rose
CommandSpecwith a test (no new user action)assets/ordocs/images/have a row inATTRIBUTION.md(none added)How it was checked
cargo xtask pre-pushon this branch.the_window_opens_where_it_was_leftandcoming_back_further_down_than_the_page_reaches_leaves_the_window_still(fails without the scroll change).🤖 Generated with Claude Code