[PWGEM] Unify QC + MaterialBudgetTasks - #17731
Open
Steffimro wants to merge 4 commits into
Open
Conversation
|
O2 linter results: ❌ 6 errors, |
Steffimro
marked this pull request as ready for review
September 2, 2026 14:47
Steffimro
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
jokonig,
mhemmer-cern and
reygers
as code owners
September 2, 2026 14:47
Collaborator
|
Error while checking build/O2Physics/code-check for 1583228 at 2026-09-02 18:20: Full log here. |
Collaborator
|
It looks like the old tasks are not in the Legacy folder with this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This task restructures the PCM QC code: the standalone pcmQCMC task and the material-budget part of MaterialBudget.cxx are merged into pcm-qc as process functions, the old tasks are moved to the legacy folder.
Process functions (all off by default except processQC):
processQC / processQCML: data QC as before, with classical or ML-based selection. Added default histograms: Rxy/eta/phi vs pT, an (alpha, qT, pT) sparse for pT-sliced Armenteros plots, psi_pair vs pT (ML path), TPC nsigma_el vs eta.
processPCMQCMC / processPCMQCMCML: former pcmQCMC. QC observables split by MC truth class (primary, fromWD, fromHS, fromPi0Dalitz, fromEtaDalitz, candidate as purity denominator) including pT/eta/phi and conversion-point resolution. MC histograms are only booked when an MC process is enabled.
processGen: generator-level reference (needs binned generated-pT derived data), plus wide-R conversion-point maps
processRecoQA: new, runs on AO2Ds before skimming. Single-photon efficiency analysis possible (converted -> both legs tracked -> both legs in V0Legs -> candidate in V0PhotonsKF) as {pT, eta, phi, Rconv} sparses, duplicate counters and missing-leg diagnostics, to separate tracking losses from SVertexer losses.
New optional groups: materialBudgetSettings_group (conversion-point maps, overall and per detector region), mcAnalysisModeSettings_group (detailed resolution, collision-association QA, true-association requirement), genSettings_group, recoQASettings_group, qaSettings_group (cut variables vs pT before/after the selection). All new output is off by default.