[PWGCF] Femto: add optional kT-dependent dphistar cut in CPR - #17488
Open
IgorPtak wants to merge 1 commit into
Open
[PWGCF] Femto: add optional kT-dependent dphistar cut in CPR#17488IgorPtak wants to merge 1 commit into
IgorPtak wants to merge 1 commit into
Conversation
IgorPtak
requested review from
alibuild,
ariedel-cern,
dimihayl,
dsarkaralice,
lauraser,
victor-gonzalez and
wrzesaCERN
as code owners
August 18, 2026 06:56
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Hi @IgorPtak , in modes.h such that, in a configurable, the analyzers can then set an integer indicating which kinematic variable they want to cut on. Then we also have to rework the fill function of the CPR manager. Here, we can, in principle, pass the PairHistManager by reference instead of a float and then call a specific getter; there is no need to recompute any pair property. And to keep the interface simple, we can generally set dphistar to a formula (maybe we should also do the same for deta to be symmetric?). |
ariedel-cern
requested changes
Aug 19, 2026
ariedel-cern
left a comment
ariedel-cern
left a comment
Collaborator
There was a problem hiding this comment.
see previous comment
Contributor
Author
I'll add CprCutKinematicVariable to modes.h and expose it as a configurable, and make deta a formula too for symmetry. On passing the PairHistManager: agreed. Two things I hit: only getKstar() exists, so getKt()/getMt() need adding and isClosePair() is called before PairHistManager.setPair(), so the values aren't computed yet. The rectangular cut wasn't in my original scope but I'm happy to add it. |
Collaborator
|
Error while checking build/O2Physics/o2 for def19b7 at 2026-08-31 18:23: Full log here. |
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for def19b7 at 2026-08-31 11:18: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.