Repository navigation
chore(loop): re-open a loop PR's review when a new commit arrives - #83
Merged
Merged
Conversation
Contributor
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
D26, the review path. A
pull_request.synchronizeon a loop PR was skipped whenever thetask was not claimable, and
pr-reviewleaves it in exactly such a state:rejected— request-changes (chore(loop): mine the uploaded agent sessions and feed them to retro #82's verdict);waiting-merge— approved, awaiting a human.So a revised loop PR could never be reviewed again: every later push logged
skip: task #82 not claimable (status=rejected). That is the loop's only path backafter its own review, and the reason #82's fix commit could not reach a reviewer
without a new task.
Change
shared/route.mjs:reviewReopenOf({ eventName, action, event }, status)— returnsthe PR number only for
pull_request.synchronizewith statusrejectedorwaiting-merge.entry.mjsdoRun: before the claim check, that event moves the task toready(timeline
reopened-for-review) so the routedpr-reviewactually runs.scripts/loop/README.md: D26 closed for the review path; its second face (a PR tasktriaged into
waiting-human) is split out as D38 — still open, because reopening itneeds a deliberate human act on the PR, not another
claimabilityexception (D29).Proof
End-to-end proof: after this lands, pushing the miner fixes to
loop/77-session-miningmust log
review reopen: task #82 rejected → ready, then startstage=pr-review.Risk
Host scripts only. The widening is bounded to two terminal states on one event; bot
pushes do not raise
synchronizeruns at all (GITHUB_TOKEN events are suppressed), sothis cannot make a PR re-review itself in a loop.