fix(ftp): reconnect stale pooled sessions before downloading - #364
Merged
Merged
Conversation
DATASUS drops idle FTP control connections. When the sync pipeline reused a pooled session, RETR hung until the socket timed out and the worker thread's exception was never retrieved, stalling the whole run. Ping the session with NOOP and reconnect when stale before every transfer, and use a non-blocking close (quit can hang on a dead link).
luabida
force-pushed
the
fix/ftp-stale-session
branch
from
October 1, 2026 17:36
5214682 to
d072a93
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage ? 97.20%
=======================================
Files ? 180
Lines ? 22908
Branches ? 0
=======================================
Hits ? 22267
Misses ? 641
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 2.11.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DATASUS drops idle FTP control connections. When the sync pipeline reused a pooled session, RETR hung until the socket timed out and the worker thread's exception was never retrieved, stalling the whole run. Ping the session with NOOP and reconnect when stale before every transfer, and use a non-blocking close (quit can hang on a dead link).