Repository navigation
Fix celsius conversion for dew point temperature - #12
Merged
Merged
Conversation
The celsius argument was only applied to Temperature-Air-2m, so Dew-Point_Temperature-2m was silently returned in Kelvin despite the documentation stating otherwise. Correct the variable name in check_temp_vars, which held the CDS API spelling instead of the file name spelling, and use that helper in ag5_extract.numeric rather than a hardcoded comparison. # Conflicts: # R/extract.R # man/ag5_extract.Rd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ag5_extract.numeric() now calls check_temp_vars() instead of comparing against Temperature-Air-2m directly
check_temp_vars() corrected to the file-name spelling Dew-Point_Temperature-2m
the Kelvin/Celsius sentence moved from @PARAM ncores to @PARAM celsius, with man/ag5_extract.Rd updated to match