Skip to content

Fix celsius conversion for dew point temperature - #12

Merged
dbrownf merged 2 commits into
masterfrom
fix-celsius-dewpoint
Nov 5, 2026
Merged

dbrownf merged 2 commits into
masterfrom
fix-celsius-dewpoint

Conversation

@dbrownf

@dbrownf dbrownf commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

ag5_extract.numeric() now calls check_temp_vars() instead of comparing against Temperature-Air-2m directly
check_temp_vars() corrected to the file-name spelling Dew-Point_Temperature-2m
the Kelvin/Celsius sentence moved from @PARAM ncores to @PARAM celsius, with man/ag5_extract.Rd updated to match

The celsius argument was only applied to Temperature-Air-2m, so Dew-Point_Temperature-2m was silently returned in Kelvin despite the documentation stating otherwise. Correct the variable name in check_temp_vars, which held the CDS API spelling instead of the file name spelling, and use that helper in ag5_extract.numeric rather than a hardcoded comparison.

# Conflicts:
#	R/extract.R
#	man/ag5_extract.Rd
The sentence describing the Kelvin to Celsius conversion was placed after @PARAM ncores, so it documented ncores instead of celsius. Move it under @PARAM celsius and regenerate the affected Rd entries.
@dbrownf
dbrownf merged commit c6d4749 into master Nov 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant