Repository navigation
Conversation
Node.js requirement was pinned to the EOL v18.18.0; bump to v22.11.0 to match agoric-sdk's engines range (^22.11 || ^24.14). The Yarn install step still described Yarn 1 with a corepack pin of 1.22.5, but the default dapp-offer-up template pins Yarn Berry 4.7.0; update the guide to match. Fix a bigint literal bug in the sell-concert-tickets code sample (bare `n` where `1n`/`10n` bigints are required). Retire deploying.md, which described the retired ag-solo `agoric deploy` model (home object, contract/deploy.js + api/deploy.js, REPL) that no longer matches any current dapp template; the current core-eval flow is already documented accurately in explainer-deploying-a-smart-contact.md, so redirect the old path there and fix its one inbound link plus a stale zoe.install() code sample in eventual-send.md. Fix "Smart Contact" title typo. Soften a swaparoo doc's dated "will be addressed in an upcoming release" promise about a namesByAddressAdmin bug that is still unfixed upstream. Bump one ui-tutorial dependency pin (@interchain-ui/react 1.22.11 -> 1.23.11) to match what agoric-labs/ui-tutorial's checkpoint branches actually pin. Verified against live agoric-sdk (engines, CLI defaults), the dapp-offer-up and dapp-agoric-basics template repos, and the agoric-labs/ui-tutorial checkpoint-1..5 branches: the seven ui-tutorial pages' code samples and dependency pins (@agoric/react-components, @agoric/web-components, @agoric/rpc, @agoric/store, cosmos-kit) match the actual checkpoint branches exactly, despite lagging the unreleased tip of Agoric/ui-kit, whose API has since diverged in breaking ways (AgoricProvider props, useAgoric's package). Bumping those pins to ui-kit's latest would break the tutorial rather than fix it, since agoric-labs/ui-tutorial has not itself been updated; left as-is. contract-rpc.md's mainnet1B source permalinks were also re-verified line-by-line against that tag and found accurate, contrary to the survey's suspicion of drift. yarn docs:build (including the internal link checker) passes locally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the getting-started onboarding cluster against current
agoric-sdk:v18.18.0tov22.11.0, matching agoric-sdk'sengines.node(^22.11 || ^24.14).yarn set version 1.22.5, but the defaultdapp-offer-uptemplate pins Yarn Berry ("packageManager": "yarn@4.7.0"). Corrected accordingly.backRowused a barenwhereAmountMath.make/maxTicketsneed bigint literals).deploying.md, which described the retired ag-soloagoric deploymodel (homeobject,contract/deploy.js+api/deploy.js, the REPL,agoric initdefaulting todapp-fungible-faucet) that matches no current template. The current core-eval flow is already documented accurately inexplainer-deploying-a-smart-contact.md; added a redirect from the old path and fixed the one inbound link (plus a stalezoe.install(bundle)sample, nowzoe.installBundleID(bundleId)) inguides/js-programming/eventual-send.md.@interchain-ui/react1.22.11->1.23.11) to match whatagoric-labs/ui-tutorial's checkpoint branches actually pin.Verification notes
Checked against live
agoric-sdk(engines, CLI defaults inpackages/agoric-cli/src/main.js), theAgoric/dapp-offer-upandAgoric/dapp-agoric-basicstemplate repos, andagoric-labs/ui-tutorial'scheckpoint-1throughcheckpoint-5branches.Notably, the seven
ui-tutorial/pages' code samples and dependency pins (@agoric/react-components,@agoric/web-components,@agoric/rpc,@agoric/store,cosmos-kit) turn out to match the actual checkpoint branches exactly, word for word in the React source. They lag the unreleased tip ofAgoric/ui-kit, whose API has since diverged in breaking ways (AgoricProviderprops, which package exportsuseAgoric), butagoric-labs/ui-tutorialitself has not been updated to that tip. Bumping the docs' pins to ui-kit's latest would break the tutorial rather than fix it, so those pins were left as-is (aside from the one confirmed drift above).contract-rpc.md's source permalinks pinned to themainnet1Btag were also re-checked line-by-line against that tag and found accurate.Test plan
yarn docs:build(includes the internal link checker) passes locally🤖 Generated with Claude Code