Repository navigation
[softposconfiguration] Code generation: update services and models - #411
AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the auto-generated SoftPOSConfiguration service and its SessionAuthenticationApi class to the Adyen Ruby SDK. A critical issue was found in SessionAuthenticationApi where the undefined constant DEFAULT_VERSION is referenced in the initializer, which will cause a NameError at runtime when instantiated without a version argument.
| attr_accessor :service, :version | ||
|
|
||
| def initialize(client, version = DEFAULT_VERSION) |
There was a problem hiding this comment.
The constant DEFAULT_VERSION is referenced as a default argument in the initialize method, but it is not defined within SessionAuthenticationApi or its parent class Service. This will result in a NameError at runtime if the class is instantiated without explicitly passing a version argument. Defining DEFAULT_VERSION = 3 within this class resolves the issue.
attr_accessor :service, :version
DEFAULT_VERSION = 3
def initialize(client, version = DEFAULT_VERSION)
4757dd6 to
0aab011
Compare
0aab011 to
a6f5b20
Compare
|
This PR contains the automated changes for the
softposconfigurationservice.Adyen/adyen-openapi@d449f09
The commit history of this PR reflects the
adyen-openapicommits that have been applied.