Repository navigation
[foreignexchange] Code generation: update services and models - #406
AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ForeignExchange service and its associated RatesApi to calculate currency amounts. The review feedback highlights two critical issues: first, DEFAULT_VERSION is undefined in RatesApi, which will cause a NameError upon initialization; second, the 'ForeignExchange' service name is not yet supported in Adyen::Client#service_url_base, which will lead to an ArgumentError during API calls.
| def initialize(client, version = DEFAULT_VERSION) | ||
| super(client, version, 'ForeignExchange') | ||
| end |
There was a problem hiding this comment.
The constant DEFAULT_VERSION is not defined within the RatesApi class or the Adyen module scope, which will result in a NameError: uninitialized constant Adyen::RatesApi::DEFAULT_VERSION when initializing RatesApi without explicitly passing a version. Defining DEFAULT_VERSION = 1 inside the RatesApi class resolves this issue.
DEFAULT_VERSION = 1
def initialize(client, version = DEFAULT_VERSION)
super(client, version, 'ForeignExchange')
end|
|
||
| DEFAULT_VERSION = 1 | ||
| def initialize(client, version = DEFAULT_VERSION) | ||
| @service = 'ForeignExchange' |
There was a problem hiding this comment.
The service name 'ForeignExchange' is not yet supported in Adyen::Client#service_url_base (defined in lib/adyen/client.rb). Any API call to this service will raise an ArgumentError: Invalid service specified. Please ensure Adyen::Client is updated to support the 'ForeignExchange' service base URL.
55521fb to
a216f07
Compare
7329c31 to
038f8fb
Compare
5c5d6ce to
b28f462
Compare
a530da0 to
13a9cf1
Compare
41de50b to
c5639aa
Compare
baf357b to
4c98123
Compare
4c98123 to
d2ab8bc
Compare
|
This PR contains the automated changes for the
foreignexchangeservice.Adyen/adyen-openapi@d449f09
The commit history of this PR reflects the
adyen-openapicommits that have been applied.