Repository navigation
ci: run the documented verification checks on every push and pull request - #76
Open
theLeverager1705 wants to merge 1 commit into
Open
theLeverager1705 wants to merge 1 commit into
theLeverager1705 wants to merge 1 commit into
Conversation
…uest The repo has no CI, so nothing checks a PR before review. This workflow runs the local checks listed in docs/VERIFICATION.md: - npm test on Node 20, 22 and 24 (engines.node is >=20; the Docker image uses 24) - npm run test:dashboard and the dashboard production build No lockfile is committed, so it uses npm install and keys the npm cache on package.json. The MongoDB integration check is left out until the Discord mock gaps in AdvancedDiscordBot#51 are closed, otherwise it would fail on every run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #74.
Adds
.github/workflows/ci.yml, which runs the local checks fromdocs/VERIFICATION.mdautomatically, so every PR shows whether it breaks the suite before anyone reviews it.npm test (Node 20 / 22 / 24)npm install,npm testDashboard check and buildnpm installinplugins/administration/web,npm run test:dashboard,npm --prefix plugins/administration/web run buildChoices worth knowing about:
main, all pull requests, and manual runs. A newer push to the same branch cancels the older run.contents: readonly,persist-credentials: falseon checkout, no secrets.npm installrather thannpm ci, and the npm cache is keyed onpackage.json.engines.nodestill allows it, so it's in the matrix. Removing it is a one-line change.How I tested it
I ran the workflow on my fork through a pull request, so it ran on the same
pull_requesttrigger it will use here:main: all 4 jobs green. 483/483 on Node 20, 22 and 24, dashboard check 15/15, build OK. https://github.com/theLeverager1705/Advanced-Discord-Bot/actions/runs/39145216114main+ the fix from fix: a plugin dependency cycle no longer stops every plugin from loading #75: all green, 488/488 on all three Node versions. https://github.com/theLeverager1705/Advanced-Discord-Bot/actions/runs/39145211627Each test job takes about 30 s, and the dashboard job about a minute. The runs show no warnings from the workflow itself. The only annotation is GitHub's notice that
ubuntu-latestis moving to Ubuntu 26.Type of change
Checklist
docs/VERIFICATION.mdalready lists.Reviewer notes
main. I didn't change any repository settings.🤖 Generated with Claude Code