Repository navigation
docs(qualia): restore 219 music/harmony annotations alongside #1571 data - #1608
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78c9a9d525
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| enriched = json.loads((ROOT / "calibrated_219.music_enriched.json").read_text(encoding="utf-8")) | ||
| original = canonical["entries"] | ||
| extra = enriched["entries"] | ||
| assert canonical["count"] == enriched["count"] == len(original) == len(extra) == 219 |
There was a problem hiding this comment.
When this script is invoked with python -O or inherits PYTHONOPTIMIZE, Python removes every assert on lines 11–21. The script can then accept an empty or mismatched sidecar and still print PASS, silently certifying corrupted archival data; use explicit conditional checks that raise exceptions instead.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in #1618 (f95c72fe): the verifier now uses explicit checks instead of assert, and compares the sidecar's values with the archived annotations. It is tested under -O.
Generated by Claude Code
1 participant
Purpose
Restore the original musical enrichment of the 219 calibrated qualia as new sidecar data, without modifying any #1571 artifacts or production ABI.
Additions only
data/qualia/calibrated_219.music_enriched.json: 219/219 ID-keyed records with verbatimmelodic_motions,harmonic_bias,truth_anchor_candidatesandneighbors.data/qualia/MUSIC_ENRICHMENT.md: provenance, archival/production boundary and limitations.data/qualia/verify_music_enrichment.py: simple lab-only ID and completeness validator.Evidence / preservation
Recovered from
AdaWorldAPI/ada-consciousness/qualia_17D/MERGED_17D.json(blob2ebe6454618e1a590e928b53116cb65f4a96c264), originally extracted fromAdaWorldAPI/Chat/music/Interval_Qualia_and_Archetypes_694dbdbf.json.Pre-publication comparison in source and #1571 data:
vector↔vector_17d,qualia↔qualia_tags).label,family,subfamily).Guardrails
calibrated_219.json,calibrated_219.bin1024, or Rust production contracts.core/music/qualia_codex.pyare codex-level example anchors and are not falsely grafted onto per-record data.Related: #1571.