Repository navigation
data(qualia): preserve original 219 musical anchors beside #1571 corpus - #1607
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d5345cb7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for field in ("melodic_motions", "harmonic_bias", "truth_anchor_candidates", "neighbors"): | ||
| assert isinstance(src[field], list), f"{ident}: missing {field}" |
There was a problem hiding this comment.
When any musical annotation is altered or emptied, this loop only confirms that the field remains a list, so the verifier still reports that the original annotations were retained. Because these four fields are the companion file's unique archival content, validate them against the pinned source blob digest or expected per-record values rather than only checking their types.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in #1618 (f95c72fe): the four musical fields are now compared against a pinned SHA-256 (MUSICAL_FIELDS_SHA256), so a value can no longer be changed silently as long as its type stays the same. A negative control covers this.
Generated by Claude Code
| assert calibrated.get("schema") == "ada.qualia.calibrated/1" | ||
| assert calibrated.get("count") == 219 | ||
| assert len(calibrated["axes_17d"]) == 17 | ||
| assert len(calibrated["entries"]) == len(original) == 219 |
There was a problem hiding this comment.
When this documented command runs with PYTHONOPTIMIZE=1 or via python -O, Python removes every assert, allowing mismatched labels, vectors, tags, counts, and duplicate IDs to reach the unconditional success message. Use explicit conditional checks that raise an exception so environment-level optimization cannot silently disable the verifier.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in #1618 (f95c72fe): the verifier now uses explicit checks that raise errors instead of assert. Under -O it rejects a corrupted copy, which the old version accepted. Negative controls run under -O in qualia-verify.yml.
Generated by Claude Code
Summary
Add the verbatim enriched 219-item musical-qualia corpus as
data/qualia/calibrated_219.musical_anchors.json, adjacent to the current #1571 data. Preserve everything already shipped, includingcalibrated_219.json,calibrated_219.bin1024, palette semantics, ABI, and readers.Added files only
data/qualia/calibrated_219.musical_anchors.json(219 original full records, verbatim, sourceAdaWorldAPI/ada-consciousness/qualia_17D/MERGED_17D.json, blob2ebe6454618e1a590e928b53116cb65f4a96c264)data/qualia/MUSICAL_ANCHORS.md(provenance, limitations and meaning)data/qualia/verify_musical_anchors.py(read-only standard-library exact join/field checks)Verification
Compared all 219 IDs to the #1571 fixture: ID sets, labels, family, subfamily, 17D coordinate values and felt tags are identical. The rich companion preserves
melodic_motions,harmonic_bias,truth_anchor_candidates, andneighborsfor all 219 entries.To rerun:
python3 data/qualia/verify_musical_anchors.py.Important boundaries
This is archive/cold-path restoration, not a request to relabel production states or overwrite existing binary data. Song examples from the original
core/music/qualia_codex.pyare documented upstream; they are not silently assigned to individual records.neighborsmay reference IDs outside this subset. The mechanically generated 806 'placeholder' states are excluded.Related: #1571.