Skip to content

refacto: typecheck the rake tasks with sorbet strict - #28

Merged
PhilMeyr merged 2 commits into
masterfrom
refacto/sorbet-strict-rake
Oct 29, 2026
Merged

PhilMeyr merged 2 commits into
masterfrom
refacto/sorbet-strict-rake

Conversation

@PhilMeyr

@PhilMeyr PhilMeyr commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Sorbet only read .rb/.rbi, so lib/tasks/activemail.rake was never checked. Same move as AdVitam/api-advitam#4544.

  • sorbet/config allows .rake.
  • Per the Sorbet FAQ ("Does Sorbet work with Rake?"), the tasks live in a top-level ActiveMailTasks class that extend Rake::DSL; the file is typed: strict.
  • sorbet/rbi/shims/rake_dsl.rbi types desc/namespace/task (same shim as api-advitam).

Behavior unchanged: srb tc, rubocop and the suite are green; both tasks still register.

Deploy

PRE: none. POST: none (no release needed: task behavior unchanged, api-advitam needs no bump).

@AdVitam AdVitam deleted a comment from claude Bot Oct 29, 2026
@AdVitam AdVitam deleted a comment from claude Bot Oct 29, 2026
@PhilMeyr
PhilMeyr merged commit 82add03 into master Oct 29, 2026
13 checks passed
@PhilMeyr
PhilMeyr deleted the refacto/sorbet-strict-rake branch October 29, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant