Repository navigation
fix(codeowners): give all five maintainers full ownership - #187
Merged
Merged
Conversation
GitHub applies only the last CODEOWNERS pattern that matches a file. The file had five separate `* @user` lines, each overriding the one above, so @bilersan alone owned most of the repo; and eight later path rules (/cmd/, /internal/, *.md, /docs/, /specs/, /hack/, /.github/, Makefile) made @josealekhine sole owner of those paths. The other three maintainers owned nothing, though the intent is that all five own everything and any one can give the code-owner approval the main ruleset requires. Collapse it to one rule, `* @josealekhine @parlakisik @CoderMungan @hamzaerbay @bilersan`, with a comment explaining the last-match rule. TestCodeownersSingleRule fails if CODEOWNERS ever holds more than that one `*` rule, the shape that broke it; owner names are not pinned, so adding a maintainer stays a one-line edit. Spec: specs/codeowners-full-ownership.md Signed-off-by: Jose Alekhinne <jose@ctx.ist>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub applies only the last CODEOWNERS pattern that matches a file.
The file had five separate
* @userlines, each overriding the oneabove, so @bilersan alone owned most of the repo; and eight later
path rules (/cmd/, /internal/, *.md, /docs/, /specs/, /hack/,
/.github/, Makefile) made @josealekhine sole owner of those paths.
The other three maintainers owned nothing, though the intent is that
all five own everything and any one can give the code-owner approval
the main ruleset requires.
Collapse it to one rule,
* @josealekhine @parlakisik @CoderMungan @hamzaerbay @bilersan, with a comment explaining the last-match rule.TestCodeownersSingleRule fails if CODEOWNERS ever holds more than
that one
*rule, the shape that broke it; owner names are notpinned, so adding a maintainer stays a one-line edit.
Spec: specs/codeowners-full-ownership.md