Repository navigation
Selfo: pie rule via the Pass button, clearer pass message - #501
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for merging Selfo and for migrating it to the new i18n structure.
This is a small follow-up, targeting
develop:by pressing Pass. The engine handles it (
passis played aspie: everypiece changes colour and the first player moves again). At any other time
Pass is rejected.
available to the second player right after the first move.
custom-buttonsflag); the generic Pass button does the job.Testing:
npm run buildpasses (including the locale checks;apgames.jsonregenerated with
npm run merge-apgames-en).rejected pass. The full suite passes with
--timeout 20000; with thedefault 2 s timeout a few unrelated heavy tests (Tumbleweed, Gliss,
Stibro) time out on my machine.
front exposes a Pass button on the second player's first turn, so
feedback on the dev server is welcome.
Question: you mentioned the
pieflag isn't needed when the engine handlesthe swap. I kept it, as in the merged version, because I'm not sure of the
side effects of removing it. Should I drop it in this PR?