Repository navigation
Conversation
…l scrollbar .md-chip's display overrode the hidden attribute, so "Resume" showed next to "Pause" at all times; overflow-x:auto on the tabs also made overflow-y scroll.
- _locales with 64 keys, English as default_locale; the store
description comes from __MSG_extDescription__ (name stays GoaBlockAD)
- i18n.js fills data-i18n / data-i18n-{title,placeholder,aria-label};
<html lang> and number formats come from the displayed translation
(langCode key) rather than getUILanguage(), which can disagree
- popup and dashboard strings, toasts included, go through t()
- CI: .github/scripts/check-i18n.js fails on missing, unknown, unused or
undefined keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traduction
_localesen 6 langues (en par défaut, fr, es, de, it, pt_BR), 64 clés. Chrome suit la langue du navigateur.__MSG_extDescription__, sous 132 caractères dans chaque langue. Le nom reste GoaBlockAD.i18n.jsremplitdata-i18netdata-i18n-{title,placeholder,aria-label}. Tous les textes du popup et du dashboard, toasts compris, passent part().<html lang>et le format des nombres viennent de la clélangCodede la traduction affichée. En test,getUILanguage()et@@ui_localerenvoyaienten_USalors que les messages étaient en français..github/scripts/check-i18n.jséchoue sur une clé manquante, inconnue, non définie ou inutilisée.Correctif UI préexistant
.md-chip { display: inline-flex }écrasait l'attributhidden, si bien que « Reprendre » s'affichait en permanence à côté de « Pause ». Constaté surmain:display: flex.Tests
lang, l'absence de texte vide ou de clé brute, les attributs traduits, l'absence de débordement horizontal, les chaînes attendues et les toasts dynamiques. Les captures ont été vérifiées à l'œil ; l'allemand, la langue la plus longue, tient dans le popup de 380 px.