Repository navigation
Fix MCP initialize lifecycle and runtime validation - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first runtime implementation incorrectly treated normal long-lived stdio MCP servers as successful only when the process exited after
initialize, and deterministic CI did not execute the runtime harness.Change
initializeresponse instead of waiting for server process exitnotifications/initialized, then terminate the disposable target process tree from the harnessNon-goals
No new adapter, no broader network mode, no credentials, no security verdict logic, no self-hosted runner, and no stronger malware-analysis claim.
Validation
The replacement harness was Python-compiled and its persistent initialize session was exercised in an isolated local root/container check. GitHub CI on this PR is the authoritative validation for the hosted-runner behavior and controlled fixtures.