Repository navigation
[46] parallel filesystem convention example - #59
Merged
asos-dominicjomaa merged 50 commits intoDec 17, 2025
Merged
asos-dominicjomaa merged 50 commits into
asos-dominicjomaa merged 50 commits into
Conversation
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
Co-authored-by: Tom Pereira <tom.pereira@johnlewis.co.uk>
move reducer replacement to a provider, rather than a toggle side-effect
TomStrepsil
marked this pull request as draft
October 22, 2025 06:36
TomStrepsil
marked this pull request as ready for review
October 23, 2025 10:14
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies and configurations across the monorepo, primarily focused on upgrading ESLint, @playwright/test, Next.js, and converting from deprecated ESLint flags.
- Updated ESLint from ^9.15.0 to ^9.38.0 and converted deprecated
unstable_config_lookup_from_fileflag tov10_config_lookup_from_file - Updated @playwright/test from ^1.49.0 to ^1.56.0 across all packages
- Updated Next.js from ^15.3.0 to ^15.5.6
- Added new parallel-folder-convention example code in express example
- Updated various package versions in lock file
- Added missing TypeScript configuration and eslint comment to disable workspace warnings
Reviewed Changes
Copilot reviewed 88 out of 91 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated eslint version and other root dependencies |
| package-lock.json | Comprehensive dependency version updates across packages |
| test/automation/package.json | Updated @playwright/test version |
| test/automation/docs/CHANGELOG.md | Documented @playwright/test upgrade |
| packages/webpack/package.json | Updated eslint flag in lint script |
| packages/webpack/docs/CHANGELOG.md | Documented eslint flag update and documentation fixes |
| packages/webpack/docs/README.md | Updated technical documentation references |
| packages/ssr/package.json | Updated eslint flag in lint script |
| packages/ssr/docs/CHANGELOG.md | Documented eslint flag update |
| packages/react-pointcuts/src/withToggledHookFactory/index.js | Simplified empty block comment |
| packages/react-pointcuts/package.json | Updated eslint flag in lint script |
| packages/react-pointcuts/docs/CHANGELOG.md | Documented eslint flag update and linebreak revert |
| packages/features/package.json | Updated eslint flag in lint script |
| packages/features/docs/CHANGELOG.md | Documented eslint flag update |
| examples/serve/package.json | Updated eslint flags and @playwright/test version |
| examples/serve/docs/CHANGELOG.md | Documented changes |
| examples/next/package.json | Updated Next.js and @playwright/test versions |
| examples/next/playwright.config.ts | Added eslint disable comment |
| examples/next/docs/CHANGELOG.md | Documented updates |
| examples/next/README.md | Removed outdated caveat about issue #50 |
| examples/express/webpack.config.js | Added extensive TypeScript configuration |
| examples/express/src/routes/parallel-folder-convention/* | Added new example code files for parallel folder convention |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…or when unpacking playwright test report
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
resolves #46
Details
Provide an example, within the expressjs harness, demonstrating a filesystem convention (enabled by #54) whereby features exist as parallel filesystems that "patch" modules on the mainline.
Include variations of:
objectProxyTogglePointusing a Proxy to retarget access to appropriate variations at access-timereact-pointcutspackagegetReducerMapfactory function as the control...to demonstrate potential toggle point configuration for these. The README.md for the example explains further.
To demonstrate the use of
valtio(previously only mentioned in passing in the features package docs), this is used to make a reactive features store on the browser.Scout Rule
updated to v5 of
upload-artifactanddownload-artifactGitHub Actionsconvert deprecated
unstable_config_lookup_from_filetov10_config_lookup_from_filenow that its stable awaiting next major version.upgrade eslint to 9.38.0
change the "config example" to use "I am" rather than "I'm" after a weird playwright failure with the "large config" example that no longer rendered the html entity for the apostrophe properly. Not gonna fight it.
update
@playwright/testto 1.56.0Screenshots
3x button click:

change to "feature 1":

2x button click:

change to "feature 2":

click "⛓️💥"

change to "feature 3":

4x button click:

change to "feature 4":

reload, with "feature2" header, then change to "feature 5":

CheckList
main.