Repository navigation
Drop the workarounds for compiler bugs that are now fixed - #109
Merged
Merged
Conversation
- `with` on TypedArray, the clamped and Float16 arrays, Array<T> and Temporal's PlainDate, PlainTime and PlainDateTime, as JavaScript names it, where it was `_with`. A T[] keeps `_with`: `with` cannot name a function. - Float16Array, DataView's Float16 accessors and Math.f16round convert through a native f16: the runtime now has the conversion helpers on every target. The software binary16 encoder goes, and with it the `value * -1` that kept -0. - ConvertingTypedArray's element conversions are private static methods of it again, not the `__ConvertedElement` namespace. - Array<T>.splice takes the removed elements from the built-in splice, which now gives them back. Needs ASDAlexander77/TypeScriptCompiler#946 (a generic class's private statics through the class name). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on ASDAlexander77/TypeScriptCompiler#946. Merge that first: without it,
ConvertingTypedArray's private static methods are reported as "not accessable".Summary
with: renamed from_withon TypedArray, Uint8ClampedArray/Float16Array,Array<T>and Temporal'sPlainDate,PlainTimeandPlainDateTime, to match JavaScript. A plainT[]keeps_with, becausewithcan't name a function in TypeScript either. Programs that call_withon these classes have to change.getFloat16/setFloat16andMath.f16roundnow convert through anf16, since the runtime has the compiler-rt helpers on every target (#943, compiler side). The hand-written binary16 encoder and decoder go, and so does thevalue * -1that kept -0.__ConvertedElement: its helpers are private static generic methods ofConvertingTypedArrayagain. A generic class's static generic methods can be called now.Array<T>.splice: takes the removed elements from the built-insplice, which now returns them, instead of reversing them to the end and popping them off.Tests
tests.ps1's first-line markers, and the stdin tests are given their input.Array<T>) pass under all four models.🤖 Generated with Claude Code