Repository navigation
Android tests: skip 00weak_field.ts under -mm=rc, which refuses @weak - #936
Merged
Merged
Conversation
@weak The release run for v0.0-pre-alpha131 failed in "Build Android tests (x86_64)" on this one program: `@weak` is refused under rc by design (own spec 93), and ctest registers the test under gc, none and own only. The Android runner compiles every test of the suite under every model, so it needs the same exception in android_skips.txt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…it tests A pull request that changes the Android runner tests the latest published release's package with that release's tester tests, but cloned the default library at today's main: a test added since (typed_array_methods.ts, DefaultLib #105) was built with alpha130's compiler and library, which lack it, and failed under gc, rc and none. create-release.yml builds a package's default library from that repository's main when the tag is pushed, so the tests are now taken from main as it was at the tag's date (alpha130: 6806d40). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release run 44522783721 (
v0.0-pre-alpha131) failed in Android emulator / Build Android tests (x86_64). Every other job passed, but no release was created.Cause: that job compiled only one program that failed:
tester-x86_64-rc 00weak_field.ts, with "'@weak' is not supported under -mm=rc". That is by design (own spec 93), and ctest registers the test under gc, none and own only. The Android runner compiles every test under every model, so it needs the same exception. The other programs that weren't built are own'sNATIVEentries, which don't count as failures.Fix: add
00weak_field.ts rctotslang/test/android/android_skips.txt. I checked it locally with the runner (--build --suite=tester --mm=rc): the test is now listed as SKIP, and the other 694 rc programs build.The release workflow reads this file from the tagged commit, so the release needs a tag that includes this fix.
🤖 Generated with Claude Code