Skip to content

Android tests: skip 00weak_field.ts under -mm=rc, which refuses @weak - #936

Merged
ASDAlexander77 merged 2 commits into
mainfrom
android-skip-weak-field-rc
Nov 19, 2026
Merged

ASDAlexander77 merged 2 commits into
mainfrom
android-skip-weak-field-rc

Conversation

@ASDAlexander77

Copy link
Copy Markdown
Owner

Release run 44522783721 (v0.0-pre-alpha131) failed in Android emulator / Build Android tests (x86_64). Every other job passed, but no release was created.

Cause: that job compiled only one program that failed: tester-x86_64-rc 00weak_field.ts, with "'@weak' is not supported under -mm=rc". That is by design (own spec 93), and ctest registers the test under gc, none and own only. The Android runner compiles every test under every model, so it needs the same exception. The other programs that weren't built are own's NATIVE entries, which don't count as failures.

Fix: add 00weak_field.ts rc to tslang/test/android/android_skips.txt. I checked it locally with the runner (--build --suite=tester --mm=rc): the test is now listed as SKIP, and the other 694 rc programs build.

The release workflow reads this file from the tagged commit, so the release needs a tag that includes this fix.

🤖 Generated with Claude Code

ASDAlexander77 and others added 2 commits November 19, 2026 13:24
@weak

The release run for v0.0-pre-alpha131 failed in "Build Android tests (x86_64)" on this one
program: `@weak` is refused under rc by design (own spec 93), and ctest registers the test under
gc, none and own only. The Android runner compiles every test of the suite under every model, so
it needs the same exception in android_skips.txt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…it tests

A pull request that changes the Android runner tests the latest published release's package with
that release's tester tests, but cloned the default library at today's main: a test added since
(typed_array_methods.ts, DefaultLib #105) was built with alpha130's compiler and library, which
lack it, and failed under gc, rc and none. create-release.yml builds a package's default library
from that repository's main when the tag is pushed, so the tests are now taken from main as it
was at the tag's date (alpha130: 6806d40).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ASDAlexander77
ASDAlexander77 merged commit 0c6d169 into main Nov 19, 2026
10 checks passed
@ASDAlexander77
ASDAlexander77 deleted the android-skip-weak-field-rc branch November 19, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant