Repository navigation
Harden side menu lifecycle and strictness - #1
Merged
Merged
Conversation
Stabilize menu behavior by cleaning up global listeners/timers, replacing continuous polling with resize-driven recompute, guarding null-sensitive frontend helpers, and tightening backend typing/comparisons and user-session handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request hardens
side_menuruntime stability and maintainability by fixing lifecycle leaks, removing unnecessary polling, and improving strictness and null-safety across frontend and backend code paths.Changes
setIntervallayout polling inStandardMenu.vuewith resize-drivenrequestAnimationFramerecomputation.aria-label) and removed undefined binding usage.menu,dom,setting).await awaitand unused imports insrc/store/nav.js.0could be incorrectly dropped.declare(strict_types=1);acrosslib/PHP files.in_arraychecks with strict checks.\OC::$serversession access to injectedIUserSession.Impact
Validation
php -l) passes for all files underlib/.