Repository navigation
docs(estadistica): colour and font come only from the suite's theme - #285
Merged
Merged
Conversation
The developer reference says the app reads only Nextcloud's CSS variables and the suite's theme, that `npm run lint-js` fails on a colour or a font written under src/, and that `make test-browser` opens every view in the light and the dark theme (APS-Conecta/estadistica#92). Assisted-by: claude-code:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The colour-and-font invariant sat between the establishment invariant and its keys table, so the table read as part of the theme's. It now follows the keys' paragraph, and names SVG paint attributes among what the lint gate reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of APS-Conecta/estadistica#92:
desarrollo/estadistica.mdgains the invariant that colour and typography come only from the theme (Nextcloud's CSS variables, Theming's primary, gestion-aio'sserver.css), thenpm run lint-jsgate that enforces it (CSS and SVG paint attributes), andmake test-browser's light and dark pass over every vista.Before: the page only said the charts use Nextcloud's colour variables. After: one invariant paragraph under «Propósito y diseño», after the establishment invariant's keys table and its paragraph, so that table sits right under the prose that introduces it.
Gate (roster shallow-cloned under a scratch
APS_ORG_ROOT,SUITE_SRC=$APS_ORG_ROOT/gestion-aio): actionlint,make html test fidelity term-check rebrand-check linkcheck check-siteandmake structureall exit 0. Every step ran.🤖 Generated with Claude Code