Repository navigation
feat: a shipped-bundle caller — the one app whose bundle ships as committed bytes - #3
Merged
Merged
Conversation
…mitted bytes side_menu (instalador #38) is seeded from upstream's AGPL 6.0.1 tarball because its source is unreachable, so it carries no build manifest of its own: its js/ bundle is vendored bytes, not something the release builds. The packer refused any committed js/*.js — the right default, kept — and gains the one exception, named by the caller: `shipped-bundle: true` makes the workflow set SHIPPED_BUNDLE=1, which accepts the committed bundle and still refuses a package.json beside it, because a buildable app builds instead of shipping. Deterministic packing, the tag/version check, the signature.json refusal and signing all stay exactly as they are. - scripts/pack-app.sh: the bundle rule and its exception, one branch; two self-test arms (a shipped bundle packs and ships; a package.json refuses it) — 27 checks OK. - app-release.yml: the shipped-bundle input, documented at the top with the one caller it exists for; actionlint clean. Assisted-by: pi:glm-5.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
shipped-bundle: true, a new input of the shared release workflow, for the one kind of caller that needs it: side_menu (instalador #38), seeded from upstream's AGPL 6.0.1 tarball because its source is unreachable, with no build manifest of its own — itsjs/bundle is vendored bytes, not something the release builds.scripts/pack-app.shkeeps the committed-bundle refusal as the default and adds the named exception:SHIPPED_BUNDLE=1accepts a committedjs/bundle and still refuses apackage.jsonbeside it, because a buildable app builds instead of shipping. Deterministic packing, the tag/version check, thesignature.jsonrefusal and signing are untouched..github/workflows/app-release.ymlcarries the input down to the pack step.Evidence
pack-app.sh --self-test: 27 checks, 0 failed (two new arms: a shipped bundle packs and ships; apackage.jsonrefuses it).shellcheckclean;actionlintclean.Instalador #38 rides this; its caller pins the SHA this PR lands on main.
Assisted-by: pi:glm-5.3