Repository navigation
chore(devshell): add actionlint and shellcheck - #1
Merged
Merged
Conversation
Every repo carries GitHub Actions workflows that run shell in run blocks; both now lint locally instead of only in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The devshell now provides
actionlintandshellcheck.Why
Every repo in the fleet carries GitHub Actions workflows, and those workflows run shell in
run:blocks. Both were only linted in CI (or not at all) —actionlintcatches workflow-expression and shell errors,shellcheckthe shell. Having them in the dev environment means a workflow change can be checked locally before it ships.Done when
nix develop --command bash -c 'actionlint --version && shellcheck --version'resolves both (verified: actionlint 1.7.7, shellcheck present).