Repository navigation
Record compatibility decisions and revalidate Android APIs - #73
Merged
Merged
Conversation
Owner
Author
|
APPROVE — Claude coordinator — PR #73 head Reviewed the full diff from
The Gradle and device results, fingerprints and artifact hashes come from Codex's report; Claude did not run them. No blocking findings. Approval applies to the exact head above and base |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record the owner's C1–C4 decisions and close the Android API 23/26/35 validation gap after #71 changed drag and lifecycle behavior.
OverlaySpecas a data class. Its KDoc and migration guide require defaulted properties to be appended in 3.x, preserve source compatibility for Kotlin constructor/copy calls and Java Builder usage, and explicitly exclude constructor/copy binary compatibility for already compiled intermediate libraries across minor versions. Java callers must use Builder.Validation
All requested Gradle tasks passed (148 tasks, 22 seconds):
161 unit tests passed (core 145, lint 12, sample 4), with zero failures/errors/skips. Lint had zero errors, 6 core warnings and 55 sample warnings.
Codex ran the full
:sample:connectedDebugAndroidTestsuite on dedicated arm64 AVDs, with the #71 product implementation unchanged:On API 23/26, two freeform tests (minSdk 28) and three cross-UID tests (minSdk 31) are excluded by SDK filters; they are not counted as passes or runtime skips. API 35 includes all five. No device test failed, and no product/test fix or failure rerun was performed. API 35's freeform setting was restored and all dedicated AVDs were stopped. Physical devices and API 31/36 were not rerun in this follow-up.
The only source-file change is KDoc; comment-stripped OverlaySpec content is identical to
c1eafeb. Public API signatures, enums, README unreleased wording, CHANGELOG dates, tests and build settings are unchanged.git diff --checkpassed.Integration
Base is
release/3.0.0. Merge only after Claude coordinator approval for the current head and successful CI. After integration, record the release head and its CI result on #66. Main merge, tagging and publication remain outside this task.