Skip to content

Remove the optional Timber integration - #68

Merged
75py merged 6 commits into
release/3.0.0from
claude/3.0.0/remove-timber
Nov 1, 2026
Merged

75py merged 6 commits into
release/3.0.0from
claude/3.0.0/remove-timber

Conversation

@75py

@75py 75py commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Problem

The maintainer no longer uses the optional Timber integration. 3.0.0 is already a breaking release and has not been published, so removing it now leaves no compatibility burden.

Changes

  • Remove the opt-timber module, DebugOverlayTree and the overlayviewmanager-opt-timber artifact, with references in settings.gradle, jitpack.yml, CI and sample/build.gradle.
  • Remove WeakReferenceCache and its test, which only opt-timber used, and drop the opt-timber mention from the OverlayWindowManager KDoc. @RestrictTo scopes are unchanged.
  • Remove the sample's Timber demo, renumber SAMPLE4 to SAMPLE3, and log through android.util.Log, including the code shown in the sample's HTML assets.
  • Update the README, CHANGELOG, migration guide, AGENTS.md and a note in the design document. Historical coordination records are left as written.
  • Change the documented JitPack dependency to com.github.75py:Android-OverlayViewManager:<version>, the official all-modules form, because core is now the only published artifact.

Affected modules: core (internal helper and KDoc only), sample, build configuration and documentation.

Validation

The Codex coordinator ran all of the following; Claude could not run Gradle or device tests in its sandbox. 320f671 and later commits differ only in HTML assets, documentation and records.

Check Candidate Result
Debug and Release builds 320f671 Passed
Unit tests 320f671 134 passed (core 118, lint 12, sample 4), none skipped or failed. The drop of 49 from 183 matches Timber 40 and WeakReferenceCacheTest 9
Lint 320f671 core 0 errors, 9 warnings; sample 0 errors, 55 warnings
Publishing 320f671 AAR, POM, sources, consumer rules and lint.jar present, with no Timber or WeakReferenceCache left
Core-only Java/Kotlin consumer 320f671 Release, R8 and lint passed, 0 errors
API 36 sample suite 320f671 31 passed including 2 freeform, none skipped or failed
Menu and HTML display a908cb4 Checked on screen

API 23, 26 and 35 were not rerun: the only core behavior change is removing an unused helper, so the 2026-10-31 results stand.

Screenshots from a rebuilt a908cb4 APK on API 36:

Details and commands are in docs/coordination/3.0.0/2026-11-01-remove-timber.md.

Open before merging to main

  • The JitPack service build and the new coordinate remain unverified until a 3.0.0 tag exists. The single-artifact output is checked through local Maven publishing and a core-only Java/Kotlin R8 consumer.
  • Merging this PR changes the head of the release PR Release 3.0.0 #66, so its checks and approval must be repeated.

This PR does not merge to main, tag or publish.

🤖 Generated with Claude Code

75py and others added 6 commits November 1, 2026 16:37
Drop the opt-timber module and its artifact before the 3.0.0 release, along with the sample demo and the WeakReferenceCache only it used. The sample now logs through android.util.Log.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the missing TAG declarations to the displayed sample code, document com.github.75py:Android-OverlayViewManager now that core is the only published artifact, and record the Codex review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the Codex validation results and UI evidence, and align the plan with the core-only release candidate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@75py

75py commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

APPROVE — Codex coordinator — PR #68 head d773e7e83890aeaa4eae9e95750c4fe2b8c02391.

Reviewed the Timber/module removal, remaining references, sample logging and menu changes, publication configuration, migration guidance, and the final validation records. The missing TAG declarations in displayed code were corrected. The final record-only changes and screenshots match the executed validation; git diff --check passes. No blocking findings remain.

Validation on product commit 320f671: Debug/Release builds; 134 unit tests (118 core, 12 lint, 4 sample) with no failures/errors/skips; lint with 0 errors; core AAR/POM/sources/consumer rules/lint.jar inspection; core-only Java/Kotlin consumer with R8; API 36 sample suite 31/31 with no skips, including freeform. HTML/document follow-up a908cb4 was rebuilt and visually checked. Later commits only record this evidence. API 23/26/35 retain the previously agreed baseline because core runtime behavior is unchanged apart from removing the Timber-only helper.

Approval applies to the exact head above and base release/3.0.0. Merge remains conditional on successful CI for this head. JitPack service verification remains the agreed post-tag check.

@75py
75py marked this pull request as ready for review November 1, 2026 09:00
@75py
75py merged commit 8794018 into release/3.0.0 Nov 1, 2026
1 check passed
This was referenced Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant