Repository navigation
bug: the node pages assume 2 CPUs per server when the setting was never saved, as the api does - #1048
Merged
Merged
Conversation
lukepolo
changed the title
lukepolo
force-pushed
the
bug/pinned-server-capacity
branch
from
October 23, 2026 20:55
7f17b10 to
727364f
Compare
…er saved, as the api does
lukepolo
force-pushed
the
bug/pinned-server-capacity
branch
from
October 23, 2026 20:56
727364f to
4a3fd15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
number_of_cpus_per_serverwas never saved, the api gives each pinned server 2 CPUs (match-assistant.service.ts,dedicated-servers.service.ts), but the node pages split capacity by 1 and the settings form showed 1. Max servers read about double what the scheduler admits.nodeSettingsdefaults CPUs per server to 2threads − 1is exact