Skip to content

perf: the tournament check-in list stops polling elo it never shows #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepolo merged 1 commit into from
Oct 23, 2026
Merged

perf: the tournament check-in list stops polling elo it never shows #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/tournament/TournamentDetail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,9 @@ const checkInTeamsSubscription = generateSubscription({
player_steam_id: true,
role: true,
checked_in_at: true,
player: playerFields,
// The check-in panel shows these players without elo and the review
// doesn't show them at all.
player: playerFieldsWithoutElo,
},
],
roster_aggregate: [
Expand Down
8 changes: 8 additions & 0 deletions tests/components/tournament/TournamentDetailSharedLive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,14 @@ describe("the check-in list for a signed-in player", () => {
]);
});

it("leaves elo out of the check-in list, which never shows it", async () => {
await mountCheckIn("moderator");

const [list] = checkIn();
expect(print(list.query)).toContain("is_banned");
expect(print(list.query)).not.toMatch(/^\s*elo\b/m);
});

it("reads the whole list on one subscription for a moderator", async () => {
await mountCheckIn("moderator");

Expand Down
Loading