Repository navigation
bug: a simulated server whose demo upload times out finishes the map instead of stopping in UploadingDemo - #277
Merged
Conversation
…instead of stopping in UploadingDemo for good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HttpClient timeout throws TaskCanceledException, an OperationCanceledException, which the demo upload's catch let through and the map run swallowed as a stop: the server sat in UploadingDemo for good and played nothing more. In the load lab, 18 of 20 simulated servers stopped this way when the api fell behind in a 2,000-user run. A failed upload is now logged and the map finishes, as the plugin does; only a run that was really stopped ends quietly, and anything else that ends a run is logged. The new test times the upload out: it stopped in UploadingDemo before.