Repository navigation
bug: a match whose lineups are smaller than its type, like a 3v3 Competitive, expects the players it has instead of pausing every round for ones that don't exist - #274
Merged
Conversation
…etitive, expects the players it has instead of pausing every round for ones that don't exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin expected the type's player count, 10 for Competitive, everywhere: round start pauses a round that starts short of it, readiness waits for it, a restore waits for it and a lineup's capacity is half of it. A 3v3 Competitive therefore paused at every round start for four players that don't exist, and with ready_setting Players never readied. Both plugins now expect two sides of the type's size unless both lineups are smaller, in which case each side is the larger lineup; a full or substitute-padded roster still expects the type's count, and an empty one falls back to it. Found by the simulator, which uses the same shared entity.
Tests (ExpectedPlayerCountTests, both apps): the type's count for full rosters (Competitive 5v5, 6v6 with subs, 5v3; Wingman, Duel, Rush), the roster for lineups smaller than the type (3v3 is 6), the type's count before anyone is in a lineup. swiftly 363, counterstrikesharp 304 passed.