Skip to content

bug: plugin.sh retires only Ingresses that exist, never without a route, and keeps the Ingress install when the routes don't cover the site's TLS mode - #699

Merged
lukepolo merged 1 commit into
mainfrom
bug/plugin-retire-only-live-ingresses
Oct 29, 2026
Merged

lukepolo merged 1 commit into
mainfrom
bug/plugin-retire-only-live-ingresses

Conversation

@lukepolo

Copy link
Copy Markdown
Contributor

Fixes from the review of #698's Gateway API plugin installs.

  • Only Ingresses actually on the cluster are retired, and not ones the new install renders itself: a fresh install or a re-run no longer waits up to two minutes on routes (a new https Gateway stays unaccepted until its certificate issues) or reports "retired" for nothing
  • An install that renders no HTTPRoute never deletes the Ingresses it would replace
  • The Gateway API install is used only when it has an overlay for the site's TLS mode: an https site with http-only routes keeps its certificate Ingress install instead of falling back to the shared self-signed one, and a proxied site with https-only routes keeps its http install instead of applying the plugin's root directory
  • A site with no install for its TLS mode now stops with a message instead of applying the root

…te, and keeps the Ingress install when the routes don't cover the site's TLS mode
@lukepolo
lukepolo merged commit 3ec4c15 into main Oct 29, 2026
1 check passed
@lukepolo
lukepolo deleted the bug/plugin-retire-only-live-ingresses branch October 29, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant