fix: skip artifact writes when hosts are unchanged - #320
Open
xsfX20 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid rewriting the generated hosts artifact before the no-op comparison, so the scheduled workflow does not create commits when the published hosts content is unchanged. Add regression tests for unchanged and changed artifact behavior.
Why?
The repository TODO promises that unchanged hosts content will not update the generated files. The current write order rewrites
hostsbefore comparing README content, while the workflow stages all files. This patch compares first and writes generated artifacts only after a real content change.Tests
PYTHONPATH=/tmp/github520-test-deps:$PWD python3 -m unittest discover -s tests -p 'test_*.py' -vpython3 -m py_compile common.py update_ips.py fetch_ips.pygit diff --check