Skip to content

Make the container pane's first-visit copy match the detail level (usability S2) - #239

Merged
404SecNotFound merged 2 commits into
mainfrom
claude/serene-carson-0739mv-s2-pane-copy
Sep 29, 2026
Merged

404SecNotFound merged 2 commits into
mainfrom
claude/serene-carson-0739mv-s2-pane-copy

Conversation

@404SecNotFound

Copy link
Copy Markdown
Owner

Usability finding S2 from docs/reports/USABILITY-2026-09-29.md (#238).

Merge after #238. Based on main directly and built on top of the Section 06 PRs (#235 to #238). Until those land, the diff also shows them. Once they merge, it shows only 674dde0.

The problem

With Format detail off, the default since 06c, the container pane's first-visit copy still said it "itemises the container it will write, header byte by header byte". Its button read "Show the header it will write". At that detail level the itemisation shows no header bytes.

What changes

The copy and the button follow the switch:

Format detail Copy Button
Off "…itemises the container it will write: its version, its ways in and its layout." "Show what it will write"
On "…itemises the container it will write, header byte by header byte." "Show the header it will write"

scripts/palette-audit.mjs matches either button label. 01-landing.png is recaptured.

Checks

  • A new test in workflow-expert-view.spec.ts reads the copy and the button with the switch off and then on. Making the copy ignore the switch fails it (built, then run).
  • The expert-view and container-inspector specs pass (14 tests). test:palette, test:screenshots and tsc pass.
  • Screenshots: captures are not byte-deterministic for shots that contain generated values (a container, a passphrase, a seed, a clock time). This PR commits only the shot its change actually alters, which is 01-landing.png.
  • The full suite runs in CI. Locally it will run on the last PR of this batch.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GbCLpWTtk1prQYV8z6rYHr


Generated by Claude Code

404SecNotFound and others added 2 commits September 29, 2026 04:54
Section 06, part g. capture-screenshots.mjs recaptures every README and
walkthrough shot from the production export, and now also:
- takes 07-decrypt-detection.png with Format detail on, since the README
  says it shows the parameters read back from the header;
- adds walkthrough-5-steps.png, placed in WALKTHROUGH.md Part 2 with
  what each step state means;
- adds 13-recovery-tested.png and 14-verify-stale.png for the notes.

docs/reports/USABILITY-2026-09-29.md records one reviewer reading the
captured screens: one defect found and fixed, six copy and layout
findings left open with a recommendation each.

The fixed defect: after testing a backup on the Decrypt tab, the
Recovery tab said the Encrypt form's content had changed. The input
type, text box and chosen file are shared with the Decrypt tab, so its
input was read as the Encrypt form's. Content and input type are now
compared only while the form is on the Encrypt tab.
recovery-test-keeps.spec.ts checks the Recovery tab after a text-mode
and a file-mode test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GbCLpWTtk1prQYV8z6rYHr
Usability finding S2. With Format detail off, the default since
Section 06c, the pane still said it would itemise the container
"header byte by header byte", and its button read "Show the header it
will write", but the itemisation shows no header bytes at that level.

The copy and the button now follow the switch. Off: "its version, its
ways in and its layout" and "Show what it will write". On: the byte
wording, which is true then.

workflow-expert-view.spec.ts reads both. palette-audit.mjs matches
either button label. 01-landing.png is recaptured.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GbCLpWTtk1prQYV8z6rYHr
@404SecNotFound
404SecNotFound merged commit 2c3ff21 into main Sep 29, 2026
15 checks passed
@404SecNotFound 404SecNotFound mentioned this pull request Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant