Pin every workflow job to ubuntu-24.04 - #221
Merged
Merged
Conversation
All 17 jobs named ubuntu-latest. The sign job in deploy.yml and release.yml refuses to sign a manifest that the reproducible-elsewhere legs did not reproduce, and those legs run as separate jobs. GitHub moves the latest label to a new image gradually, so during a migration the publisher and the legs can land on different Ubuntu releases and a publish can be refused for a reason unrelated to the build. Pinning makes the image a deliberate change made between releases. The comment on reproducible-elsewhere records why, and the manylinux comment in pin-conformance-deps.py names the pinned image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 17 jobs across the six workflows ran on
ubuntu-latest. The sign job indeploy.ymlandrelease.ymlrunsscripts/check-reproduced-manifest.mjs, which refuses to sign a manifest thereproducible-elsewherelegs did not reproduce byte for byte. Those legs are separate jobs. GitHub moves thelatestlabel to a new image gradually, so during a migration the publisher and the legs can land on different Ubuntu releases, and a publish could be refused for a reason unrelated to the build.Pinning to
ubuntu-24.04makes the image a deliberate change made between releases.Changes
runs-on: ubuntu-latest→runs-on: ubuntu-24.04inbrowser.yml,ci.yml,conformance.yml,crypto-regression.yml,deploy.yml,release.yml(17 lines).reproducible-elsewhereinci.ymlrecords why.scripts/pin-conformance-deps.pynames the pinned image instead ofubuntu-latest.No test, script or doc asserted the old label.
docs/VERIFYING.mdsays "x86-64 Linux", which stays true.Test plan
ubuntu-latestremains under.githuborscripts.Generated by Claude Code